Skip to content

default value for subgraph name#75

Merged
YouStillAlive merged 1 commit intomasterfrom
issue-74
Jul 10, 2025
Merged

default value for subgraph name#75
YouStillAlive merged 1 commit intomasterfrom
issue-74

Conversation

@YouStillAlive
Copy link
Member

closes #74

@YouStillAlive YouStillAlive requested a review from Copilot July 10, 2025 09:28
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the customizable subgraph_name input and hardcodes the subgraph name to poolzfinancebsc in the deployment workflow.

  • Removed the subgraph_name input parameter
  • Replaced dynamic ${{ inputs.subgraph_name }} references with the static name poolzfinancebsc
Comments suppressed due to low confidence (2)

.github/workflows/deploy-subgraph.yml:12

  • Removing the subgraph_name input is a breaking change for existing workflows; consider restoring it with a default value to maintain backward compatibility.
          - "bsc"

.github/workflows/deploy-subgraph.yml:62

  • [nitpick] The subgraph name poolzfinancebsc is hardcoded in multiple steps; consider defining it once as an input default or environment variable to avoid duplication.
          echo "Deploying poolzfinancebsc version ${{ inputs.version }} to BSC"

@YouStillAlive YouStillAlive merged commit 9523466 into master Jul 10, 2025
1 check passed
@YouStillAlive YouStillAlive deleted the issue-74 branch July 10, 2025 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

predefined subgraph name for manual deployment

2 participants