Open
Conversation
DaAlbrecht
added
A-Linter
DaAlbrecht
force-pushed
the
bevy-platform-lint
branch
from
a25afec to
e8fa3d8
Compare
DaAlbrecht
force-pushed
the
bevy-platform-lint
branch
from
60b2631 to
d754d81
Compare
See: oli-obk/ui_test#341 i realized i can just mark the test as passing and dont have to look into this
DaAlbrecht
added
S-Needs-Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Add new lint that checks if a given
Tywas used from thestdthat has an equivalent inbevy_platform.Known limitations
So far, this lint only checks structs from
bevy_platform. I think this is already useful in its current state, and I think it would be a good follow-up issue to extend this and special-case traits, FnDefs, etc.Note to Reviewers
I often worked on this when I had small breaks so I would not recommend going through commit by commit, as I committed more to save my current state and not as a hint for reviewers.
A helpful look could be this clippy lint that I got recommended on Zulip: https://github.com/rust-lang/rust-clippy/blob/master/clippy_lints/src/std_instead_of_core.rs
Followup
https://docs.rs/bevy/latest/bevy/platform/thread/index.html
Closes #432