Skip to content

Made package compatible with Node 12 #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dweller23 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Made package compatible with Node 12 #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7ad7ec5
Made package compatible with Node 12
dweller23 Jan 16, 2020
57ee9cd
Bumped webdriver version
dweller23 Feb 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ var Fiber = require('fibers');
var Promise = global.Promise;
require('meteor-promise').makeCompatible(Promise, Fiber);
var wrapAsync = require('xolvio-fiber-utils').wrapAsync;
var wrapCommand = require('wdio-sync').wrapCommand;
var wrapCommand = require('@wdio/sync').wrapCommand;
var wrapAsyncObject = require('xolvio-fiber-utils').wrapAsyncObject;

var wrapAsyncForWebdriver = function (fn, context) {
Expand Down
10 changes: 5 additions & 5 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,11 @@
},
"main": "index.js",
"dependencies": {
"fibers": "^3.1.0",
"meteor-promise": "^0.8.2",
"@wdio/sync": "^5.18.7",
"fibers": "^4.0.3",
"meteor-promise": "^0.8.7",
"underscore": "^1.8.3",
"wdio-sync": "^0.7.0",
"webdriverio": "^4.14.4",
"xolvio-fiber-utils": "3.0.0"
"webdriverio": "^5.18.7",
"xolvio-fiber-utils": "git+ssh://github.com:TheBrainFamily/fiber-utils#bump-fibers-version"
Copy link

@mahmost mahmost Jan 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fails with yarn install .. need to be "TheBrainFamily/fiber-utils#bump-fibers-version" or "git+ssh://git@github.com:TheBrainFamily/fiber-utils#bump-fibers-version"

}
}