Tweak Creative Impetus Drain Behavior#407
Merged
TheCodex6824 merged 2 commits intoTheCodex6824:stagingfrom May 22, 2025
Merged
Conversation
Owner
|
LGTM, I think this way makes more sense. If it gets annoying having to charge items, we can just add more charged versions of items to the creative menu. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes Impetus API to still require the presence and ability to extract requested impetus while in creative mode in order to return true. Now creative mode simply prevents the actual consumption of impetus, rather than allowing impossible drains to happen.
Fixes #406
Behaviors that will change are:
This brings these particular interactions in line with current impetus cannon behavior, where the impetus cannon will not fire in creative mode while completely empty of charge. Alternatively, the impetus cannon could be brought in line with other behaviors and allow firing while empty if the user is in creative mode.