Update for Qiskit 1.0 #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheGupta2012
reviewed
Sep 5, 2024
| @@ -1,8 +1,8 @@ | |||
| ipython>=8.12.0 | |||
| ipywidgets==7.6.5 | |||
| numpy==1.22.2 | |||
Owner
There was a problem hiding this comment.
Can you remove numpy both from requirements and cfg file? I think it is already a dependency in qiskit
TheGupta2012
reviewed
Sep 5, 2024
| @@ -1,8 +1,8 @@ | |||
| ipython>=8.12.0 | |||
| ipywidgets==7.6.5 | |||
Owner
There was a problem hiding this comment.
Please update ipywidgets to >=8.0.5
TheGupta2012
reviewed
Sep 5, 2024
| python_requires = >=3.8 | ||
| install_requires = | ||
| ipython>=8.12.0 | ||
| ipywidgets==7.6.5 |
Owner
|
I was testing out your changes locally and I have mentioned some dependency changes. Moreover, the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the code for compatibility with Qiskit 1.0.
I relied only on the tests as I can't test this out in Jupyter due to kdk#4.