[PP-3820] Add patron blocking rules editor to the Library Settings UI…#201

Open

dbernstein wants to merge 25 commits intomainfrom

feature/PP-3820-add-patron-blocks

Commits on Mar 6, 2026

[PP-3820] Add patron blocking rules editor to the Library Settings UI for SIP2 patron auth providers
dbernstein
committed
Cosmetic improvements.
dbernstein
committed
Ensure that the error message appears next to the rule expression field.
dbernstein
committed
This update converts, to the extent that makes sense without trying to change everything at once, the style of the
dbernstein
committed
Update src/components/PatronAuthServiceEditForm.tsx

dbernstein
and
tdilauro
committed
Update src/components/PatronAuthServiceEditForm.tsx

dbernstein
and
tdilauro
committed
Change the protocolName parameter type in supportsPatronBlockingRules from string to string | null | undefined so it safely handles all values callers may pass.
dbernstein
committed
Rename renderExtraExpandedLibrarySettings to renderExtraAssociatedLibrarySettings in ServiceEditForm and PatronAuthServiceEditForm
dbernstein
committed
protocolHasLibrarySettings is now grouped with renderAdditionalContent, renderExtraAssociatedLibrarySettings, and renderExtraNewLibrarySettings
dbernstein
committed
use stable unique ID instead of array index as the key prop
dbernstein
committed
Disable"Add Rule" when any existing rule has an incomplete required field.
dbernstein
committed
Remove the rules.length > 0 condition entirely. The serverErrorMessage check alone is sufficient — it is only non-null when there is an actual error to display. Also add test coverage.
dbernstein
committed
Extract a RuleFormListItem function component
dbernstein
committed
Update src/components/PatronAuthServiceEditForm.tsx

dbernstein
and
tdilauro
authored
Update src/components/PatronAuthServiceEditForm.tsx

dbernstein
and
tdilauro
authored
Remove overly broad index signature from LibraryWithSettingsData.
dbernstein
committed
Fix imports.
dbernstein
committed
Implement blocking rule validations on the server on blur
dbernstein
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[PP-3820] Add patron blocking rules editor to the Library Settings UI…#201

[PP-3820] Add patron blocking rules editor to the Library Settings UI…#201
dbernstein wants to merge 25 commits intomainfrom
feature/PP-3820-add-patron-blocks

Commits on Mar 6, 2026

[PP-3820] Add patron blocking rules editor to the Library Settings UI for SIP2 patron auth providers

Cosmetic improvements.

Ensure that the error message appears next to the rule expression field.

This update converts, to the extent that makes sense without trying to change everything at once, the style of the

Update src/components/PatronAuthServiceEditForm.tsx

Update src/components/PatronAuthServiceEditForm.tsx

Change the protocolName parameter type in supportsPatronBlockingRules from string to string | null | undefined so it safely handles all values callers may pass.

Rename renderExtraExpandedLibrarySettings to renderExtraAssociatedLibrarySettings in ServiceEditForm and PatronAuthServiceEditForm

protocolHasLibrarySettings is now grouped with renderAdditionalContent, renderExtraAssociatedLibrarySettings, and renderExtraNewLibrarySettings

use stable unique ID instead of array index as the key prop

Disable"Add Rule" when any existing rule has an incomplete required field.

Remove the rules.length > 0 condition entirely. The serverErrorMessage check alone is sufficient — it is only non-null when there is an actual error to display. Also add test coverage.

Extract a RuleFormListItem function component

Update src/components/PatronAuthServiceEditForm.tsx

Update src/components/PatronAuthServiceEditForm.tsx

Remove overly broad index signature from LibraryWithSettingsData.

Fix imports.

Implement blocking rule validations on the server on blur

Commits on Mar 8, 2026

Ensure that save is disabled while there are client side patron block rules validation errors.

This update ensures that when a new library is newly configured but not yet saved, the "Add Library" button is not active if there is an invalid patron block rule. Also, inline errors for duplicat…

Fix linting issue.

Commits on Mar 10, 2026

Update src/components/PatronBlockingRulesEditor.tsx

Beefs up tests for PatronAuthServiceEditForm and PatronBlockingRulesEditor, adding coverage for expected error conditions as well as testing for expected button enabled/disabled states.

Fix bug where rule error messages were disappearing when a valid rule was deleted and add a test to confirm the fix.

Added note regarding possible race condition.