Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions src/components/SelfTestResult.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ export interface SelfTestResultProps {

export default class SelfTestResult extends React.Component<
SelfTestResultProps,
{}
Record<string, never>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is unrelated, but flagged by the linter since I modified this file.

> {
constructor(props) {
super(props);
Expand Down Expand Up @@ -41,9 +41,16 @@ export default class SelfTestResult extends React.Component<
success: {`${this.props.result.success}`}
</p>
{!this.props.result.success && this.props.result.exception && (
<p className="exception-description">
exception: {this.props.result.exception.message}
</p>
<>
<p className="exception-description">
exception: {this.props.result.exception.message}
</p>
{this.props.result.exception.debug_message && (
<p className="debug-description">
debug: {this.props.result.exception.debug_message}
</p>
)}
</>
)}
</li>
);
Expand Down
52 changes: 49 additions & 3 deletions src/components/__tests__/SelfTestResult-test.tsx
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
import { expect } from "chai";
import { stub } from "sinon";

import * as React from "react";
import { shallow, mount } from "enzyme";
import { mount } from "enzyme";
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is unrelated, but flagged by the linter since I modified this file.


import SelfTestResult from "../SelfTestResult";

Expand Down Expand Up @@ -89,7 +88,6 @@ describe("SelfTestResult", () => {
it("displays a result with an exception", () => {
const exception = {
class: "IntegrationException",
debug_message: "debug message...",
message: "Problem!",
};
const exceptionResult = {
Expand All @@ -106,4 +104,52 @@ describe("SelfTestResult", () => {
expect(testException.length).to.equal(1);
expect(testException.text()).to.equal("exception: Problem!");
});

it("displays debug_message when present", () => {
const exception = {
class: "IntegrationException",
debug_message: "debug message...",
message: "Problem!",
};
const exceptionResult = {
...stringResult,
...{ success: false, exception: exception },
};
wrapper.setProps({ result: exceptionResult });

const debugMessage = wrapper.find(".debug-description");
expect(debugMessage.length).to.equal(1);
expect(debugMessage.text()).to.equal("debug: debug message...");
});

it("does not display debug_message when it is empty", () => {
const exception = {
class: "IntegrationException",
debug_message: "",
message: "Problem!",
};
const exceptionResult = {
...stringResult,
...{ success: false, exception: exception },
};
wrapper.setProps({ result: exceptionResult });

expect(wrapper.find(".exception-description").length).to.equal(1);
expect(wrapper.find(".debug-description").length).to.equal(0);
});

it("does not display debug_message when it is absent", () => {
const exception = {
class: "IntegrationException",
message: "Problem!",
};
const exceptionResult = {
...stringResult,
...{ success: false, exception: exception },
};
wrapper.setProps({ result: exceptionResult });

expect(wrapper.find(".exception-description").length).to.equal(1);
expect(wrapper.find(".debug-description").length).to.equal(0);
});
});
2 changes: 1 addition & 1 deletion src/interfaces.ts
Original file line number Diff line number Diff line change
Expand Up @@ -337,7 +337,7 @@ export interface ProtocolData {

export interface SelfTestsException {
class: string;
debug_message: string;
debug_message?: string;
message: string;
}

Expand Down
9 changes: 9 additions & 0 deletions src/stylesheets/self_tests.scss
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,15 @@
border: 0.0625rem $red-dark solid;
color: #000;
}

.debug-description {
white-space: pre-line;
margin-top: 5px;
padding: 8px 10px;
background: $gray-tint;
border: 0.0625rem solid $gray-border;
border-radius: 3px;
}
}

.warning {
Expand Down