Sorting and filtering with facets in paginated feed (PP-3856)#902
Merged
tdilauro merged 5 commits intoThePalaceProject:mainfrom Mar 20, 2026
Merged
Conversation
Collaborator
Author
|
@jonathangreen Requesting your review on this one, since you have some context from our discussion. I kept the properties we talked about in and provided some context. That said, I'm perfectly willing to pull out the ones you had questions / concerns about. |
jonathangreen
approved these changes
Mar 20, 2026
Member
jonathangreen
left a comment
There was a problem hiding this comment.
This all looks good to me. I'm a bit nervous about defining the new facet/param, facet/value, and facet/group properties here, when we don't really need them for registry purposes. I'd rather we pilot these things in circulation, then move them out to other places as we find them useful, but I'm also not opposed to them going in here.
cdbb199 to
42a7781
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Organizes variations of the paginated / crawlable libraries feed (
/libraries/crawlable) around facet query parameters alone, rather than relying on aqaroute / endpoint variant to include the hidden libraries along with the production ones in the feed.Key changes:
Supported facets
?order=— sort ordermodifiedmodifiedmodified-ascmodifiednamenamename-descnamenaturaldefaultmodified(not advertised in facets)?availability=— availability filterproductionlibrary_stageandregistry_stagearePRODUCTIONhiddenTESTINGand neither isCANCELLEDallComma-separated combinations (e.g.
production,hidden) are accepted, but not advertised in facets; preferallfor the full non-cancelled list of libraries.Motivation and Context
These changes move the crawlable feed API and contents closer to OPDS standards and idioms, which should make it more accessible to the community.
[Jira PP-3856]
How Has This Been Tested?
Checklist