Skip to content

Conversation

@ChrisMaxheart
Copy link

General comment:
-) Try to use less global variable everywhere; life will be so much difficult haha. Mungkin bisa tiap kali ubah, ambil dari elemennya terus cek, terus tambah 1 instead of pake global variable wins sama loses. (Atau pake class :D)
-) naming mesti di improve
-) kurangi pake id, most of the time shld pake class.
-) mungkin belom pernah tau ini, tapi biasa css pake some naming style convention buat ngerapiin namanya; ini ada beberapa jenis yang cukup populer: http://getbem.com/introduction/ https://github.com/stubbornella/oocss/wiki http://smacss.com/
-) Btw itu tulisannya first to 5 win, tapi after 5 gaada apapun yang terjadi ahahah

-) UI nya cukup bagus hahaha, nice (although textnya mungkin harusnya bisa diperbesar)
-) Nice flex usage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant