#2327 Handle null service name in RoundRobin constructor #2350
Conversation
- Fixes ThreeMammals#2327: Unit test failures with .NET 10.0.100-preview.7 - Converts null service names to empty string - Prevents ArgumentNullException when IConfiguration returns null
| ArgumentNullException.ThrowIfNull(services); | ||
| _servicesDelegate = services; | ||
| _serviceName = serviceName; | ||
| _serviceName = serviceName?? string.Empty; |
There was a problem hiding this comment.
Wow, is this really the bug fix? 🤣
It doesn’t seem related to the .NET SDK version. Can it be reproduced in .NET 9?
There was a problem hiding this comment.
Why are the CI tests failing when all tests pass successfully on my local machine?
There was a problem hiding this comment.
Don't warry, the build is green now. Use "Re-run job" button.
Why are the CI tests failing when all tests pass successfully on my local machine?
Yes, tests pass reliably locally and remain stable in the CI environment. A few CPU-sensitive tests might occasionally fail even on local runs, but overall, the tests are optimized to perform well in both environments.
The fact is, we have many tests in Ocelot Core that run parallel logic and are sensitive to thread synchronization. Syncing threads can be unpredictable, but usually, a simple re-run does the trick.
raman-m
changed the title
|
Will you hold off on adding the |
3 participants
Fixes #2327
Proposed Changes
ArgumentNullExceptionwhenIConfigurationreturns null