tig-126-tigerjunction-the-handlebar-of-death#135
Conversation
…ger-junction into resizable-window
…ger-junction into resizable-window
This reverts commit 53c6859.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| {#if hasSearchResults} | ||
| <div | ||
| class="overflow-y-hidden min-h-0 flex flex-col shrink-0" | ||
| class:flex-1={showHandlebar} | ||
| style={bottomSectionStyle}> |
There was a problem hiding this comment.
Search results clipped on mobile left pane
Because showHandlebar is forced to false when $isMobile is true (lines 61‑64), the search results container here never gets the flex-1 height or any explicit sizing and inherits overflow-y-hidden from its parent section. On small screens, a long list of search results therefore expands beyond the fixed section height and the overflow is simply clipped with no scrollbar, making part of the results unreachable on mobile devices.
Useful? React with 👍 / 👎.
I don't think I can get the handlebar to work before course enrollment. However, I could fix the weird space thing so I'm just going to leave it at that for today.