Skip to content

tig-126-tigerjunction-the-handlebar-of-death#135

Merged
joshuamotoaki merged 20 commits intomainfrom
resizable-window
Dec 1, 2025
Merged

tig-126-tigerjunction-the-handlebar-of-death#135
joshuamotoaki merged 20 commits intomainfrom
resizable-window

Conversation

@ang-cai
Copy link
Contributor

@ang-cai ang-cai commented Nov 10, 2025

I don't think I can get the handlebar to work before course enrollment. However, I could fix the weird space thing so I'm just going to leave it at that for today.

@linear
Copy link

linear bot commented Nov 10, 2025

Copy link
Member

@joshuamotoaki joshuamotoaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It has been done

@joshuamotoaki joshuamotoaki marked this pull request as ready for review December 1, 2025 16:05
@joshuamotoaki joshuamotoaki merged commit 8d19f1e into main Dec 1, 2025
1 check passed
@joshuamotoaki joshuamotoaki deleted the resizable-window branch December 1, 2025 16:07
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment on lines +149 to +153
{#if hasSearchResults}
<div
class="overflow-y-hidden min-h-0 flex flex-col shrink-0"
class:flex-1={showHandlebar}
style={bottomSectionStyle}>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Search results clipped on mobile left pane

Because showHandlebar is forced to false when $isMobile is true (lines 61‑64), the search results container here never gets the flex-1 height or any explicit sizing and inherits overflow-y-hidden from its parent section. On small screens, a long list of search results therefore expands beyond the fixed section height and the overflow is simply clipped with no scrollbar, making part of the results unreachable on mobile devices.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants