Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the networking setup to allow the
--hostfileto list multipleaddr:porton each line, separated by whitespace, and then to listen on each and await the connections from any of them.The main change this introduces for folks who don't use this feature is that the the awaiting happens without blocking, and has a 1s sleep between each
accept()call that doesn't return a socket. This is not unlike the other end of the set-up, where connection attempts are re-attempted each second. In the worst case, this could delay the full connection by a second, where the existing code would by blocking connect as soon as sockets arrive.It wouldn't be too hard to leave the old behavior when there is a single address to listen on, by keeping both methods.
One risk of the PR is that there may be a
ToSocketAddrsfor&strthat allows whitespace, and the documentation is a bit confusing to me:The "as expected by its
FromStrimplementation ..." fragment is .. idk.