support and examples for notificationPolicy API endpoint#1
Open
masterfloda wants to merge 8 commits intoTintri:masterfrom
Open
support and examples for notificationPolicy API endpoint#1masterfloda wants to merge 8 commits intoTintri:masterfrom
masterfloda wants to merge 8 commits intoTintri:masterfrom
Conversation
added 8 commits
March 7, 2018 15:44
Contributor
|
This looks good. I have a couple things I need to figure out, though.
|
|
The @api decorators for notifications should have a 'version=v310.66' as a parameter.
- Rick -
On Tuesday, March 20, 2018, 10:57:45 AM PDT, Mark Gritter <notifications@github.com> wrote:
This looks good. I have a couple things I need to figure out, though.
-
The way we pushed to github doesn't actually allow the library to be rebuilt. I have to fix our internal tooling (and move your changes to our internal repo) before we can push a new version.
-
I am not sure whether there is a more efficient way to implement the methods you added using the "@api" decorator or not. It seems to me that at least some of the methods could be done in a more idiomatic fashion by specifying an appropriate filter type. I'll try to figure this out.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
rick-kenna
approved these changes
Mar 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://tintri.github.io/tintri-rest-api/client/http/docs/gen_api_doc/jaxrs/v310/v310/alert/notificationPolicy/index.html