fix(Lexer): Interpret minus correctly#122
Open
Dossar wants to merge 2 commits intoTomFrost:masterfrom
Open
Conversation
Author
|
@TomFrost The fix in addition to unit tests have been added in this PR. To me it looks good to merge for fixing this issue, but would like your feedback. |
chetbox
approved these changes
Jul 7, 2022
chetbox
left a comment
chetbox
left a comment
There was a problem hiding this comment.
Looks like a great fix to me and with appropriate tests. 👍🏼 I'm not a maintainer but am commenting in case it's helpful.
|
Hello @TomFrost, any idea when this PR will be merged ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #97
Incorporates the suggestion provided in this comment, courtesy of OlivierB-OB: #97 (comment)
Basically, if there is a minus sign for a negative value past the first argument, there is a parsing error. Adding comma to the list of
minusNegatesAftershould allow proper interpretation of negative values after the first argument.