Recognize null as a literal in the lexer#141
Open
hniksic wants to merge 1 commit intoTomFrost:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed fix for #140.
In
lib/Lexer.js, the_createTokenmethod handlestrueandfalseas boolean literals:But there's no corresponding handling for
null.nullis tokenized as an identifier and looked up in the context, returningundefined.This explains the strange behavior observed in #140:
[null]parses as[context.null]which evaluates to[undefined]x in [null]with{x: null}becomesnull in [undefined], and evaluates tofalsex in [null]with{}or{x: undefined} becomesundefined in [undefined], and evaluates totrue`If we handle null in
_createToken:...program from #140 works as expected, and JEXL's existing tests pass.
Note: PR #134 works around this in arithmetic operators by treating both
nullandundefinedas "nullable", but that doesn't help operators likeinthat need to distinguish between the two.