Skip to content

fix(table): fixed commit message padding #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TomPlum merged 3 commits into from
Apr 5, 2025
Merged

fix(table): fixed commit message padding #45

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1528aa2
fix(table): fixed commit message padding
TomPlum Apr 5, 2025
42a8790
test(table): updated snapshots and bumped version to 2.4.0
TomPlum Apr 5, 2025
5c61b95
test(table): added updated missing snapshot changes
TomPlum Apr 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/library/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"author": "Thomas Plumpton",
"repository": "https://github.com/TomPlum/react-git-log",
"description": "A flexible, themable, React component for visualising Git commit history, branch and tag metadata.",
"version": "2.3.0",
"version": "2.4.0",
"license": "Apache-2.0",
"type": "module",
"main": "dist/react-git-log.js",
Expand Down
6 changes: 3 additions & 3 deletions packages/library/src/__snapshots__/GitLog.spec.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42603,7 +42603,7 @@ exports[`GitLog > should render correctly and match the snapshot of the GitLog c
class="message"
data-testid="react-git-log-table-data-commit-message-0"
id="react-git-log-table-data-commit-message-0"
style="line-height: 40px; color: rgb(153, 153, 153); background: linear-gradient( to bottom, transparent 2px, transparent 2px, transparent 38px, transparent 38px );"
style="line-height: 40px; color: rgb(153, 153, 153); background: linear-gradient( to bottom, transparent 2px, transparent 2px, transparent 38px, transparent 38px ); display: flex;"
title="// WIP"
>
// WIP
Expand Down Expand Up @@ -100502,7 +100502,7 @@ exports[`GitLog > should render correctly and match the snapshot of the GitLog c
class="message"
data-testid="react-git-log-table-data-commit-message-0"
id="react-git-log-table-data-commit-message-0"
style="line-height: 40px; color: rgb(153, 153, 153); background: linear-gradient( to bottom, transparent 2px, transparent 2px, transparent 38px, transparent 38px );"
style="line-height: 40px; color: rgb(153, 153, 153); background: linear-gradient( to bottom, transparent 2px, transparent 2px, transparent 38px, transparent 38px ); display: flex;"
title="// WIP"
>
// WIP
Expand Down Expand Up @@ -216427,7 +216427,7 @@ exports[`GitLog > should render correctly and match the snapshot of the GitLog c
class="message"
data-testid="react-git-log-table-data-commit-message-0"
id="react-git-log-table-data-commit-message-0"
style="line-height: 40px; color: rgb(153, 153, 153); background: linear-gradient( to bottom, transparent 6px, transparent 6px, transparent 34px, transparent 34px );"
style="line-height: 40px; color: rgb(153, 153, 153); display: flex; background: linear-gradient( to bottom, transparent 6px, transparent 6px, transparent 34px, transparent 34px );"
title="// WIP"
>
// WIP
Expand Down
1 change: 0 additions & 1 deletion ...ages/library/src/modules/Table/components/CommitMessageData/CommitMessageData.module.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,4 @@
padding-right: 30px;
padding-left: 20px;
font-weight: 400;
display: flex;
}
2 changes: 1 addition & 1 deletion packages/library/src/modules/Table/components/CommitMessageData/CommitMessageData.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,10 @@ import { IndexStatus } from 'modules/Table/components/IndexStatus'
export const CommitMessageData = ({ index, isIndex, commitMessage, style }: CommitMessageDataProps) => {
return (
<div
style={style}
title={commitMessage}
className={styles.message}
id={`react-git-log-table-data-commit-message-${index}`}
style={{ ...style, display: isIndex ? 'flex' : undefined }}
data-testid={`react-git-log-table-data-commit-message-${index}`}
>
{commitMessage}
Expand Down