Add webview delegate #36
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fl1pflops
approved these changes
Aug 14, 2019
Hiraev
reviewed
Aug 14, 2019
|
|
||
| override fun onReceivedError(view: WebView, errorCode: Int, description: String?, failingUrl: String) { | ||
| super.onReceivedError(view, errorCode, description, failingUrl) | ||
| if (!(errorCode == -10 && "about:blank" == failingUrl)) { |
BlizzedRu
suggested changes
Aug 14, 2019
Contributor
BlizzedRu
left a comment
BlizzedRu
left a comment
There was a problem hiding this comment.
Нет переопределенного shouldInterceptRequest, соответственно и метод колбэка не дергается.
Возможно (подлежит обсуждению) стоит добавить игнорирование загрузки favicon в shouldInterceptRequest, это порождало какие-то ошибки на БСПБ, если фавикона нет. Например:
private const val FAVICON_URL_PATH = "favicon.ico"
private const val IMAGE_MIME_TYPE = "image/png"
override fun shouldInterceptRequest(view: WebView, request: WebResourceRequest): WebResourceResponse? {
// Ignoring initiated favicon request
return if (request.url.lastPathSegment == FAVICON_URL_PATH) {
WebResourceResponse(IMAGE_MIME_TYPE, null, null)
} else {
super.shouldInterceptRequest(view, request.also(onInterceptRequest()))
}
}
| } | ||
| } | ||
|
|
||
| open fun getWebViewClient() = SimpleWebViewClient(this) |
|
|
||
| import android.webkit.WebView | ||
|
|
||
| interface WebViewCallback { |
Contributor
There was a problem hiding this comment.
onInterceptRequest и onStartPageLoading нигде не вызывается :(
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.