Store tester stability #2060
Draft
Store tester stability #2060
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
palfrey
commented
Nov 19, 2025
| let client = self.client_pool.next(); | ||
| let config = client.client_config(); | ||
| if config.mocks.is_none() { | ||
| if config.mocks.is_none() && !client.is_connected() { |
Member
Author
There was a problem hiding this comment.
This means Fred isn't logging every time we call this
palfrey
force-pushed
the
store-tester-stability
branch
from
711f91a to
f2c36b6
Compare
MarcusSorealheis
approved these changes
Nov 19, 2025
Collaborator
MarcusSorealheis
left a comment
MarcusSorealheis
left a comment
There was a problem hiding this comment.
Provided you can explain why we have commented out the CI workflow, that's fine. We have never used FIXME in this repo, or not that I can recall. Otherwise, I'm good with it.
| fi | ||
| shell: bash | ||
|
|
||
| # FIXME(palfrey): Can't make this reliably run in CI |
| let res = store_clone.get_and_decode(data.clone()).await?; | ||
| if let Some(existing_data) = res { | ||
| data.version = existing_data.version + 1; | ||
| data.version = existing_data.version; |
Collaborator
There was a problem hiding this comment.
Didn't realize we tried to hack optimistic locking here. This change should prevent race conditions if the version was already up to date. Have you verified that this does not break the update logic of your tester?
MarcusSorealheis
requested changes
Nov 19, 2025
Collaborator
MarcusSorealheis
left a comment
MarcusSorealheis
left a comment
There was a problem hiding this comment.
There is some issue in the queueing mechanism.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the changes and the related issue. Please also
include relevant motivation and context.
Fixes # (issue)
Type of change
Please delete options that aren't relevant.
not work as expected)
How Has This Been Tested?
Please also list any relevant details for your test configuration
Checklist
bazel test //...passes locallygit amendsee some docsThis change is