Skip to content

Conversation

@MarcusSorealheis
Copy link
Collaborator

@MarcusSorealheis MarcusSorealheis commented Nov 25, 2025

Description

Removes client leak driving OOMs.

Type of change

Please delete options that aren't relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please also list any relevant details for your test configuration

Checklist

  • Updated documentation if needed
  • Tests added/amended
  • bazel test //... passes locally
  • PR is contained in a single commit, using git amend see some docs

This change is Reviewable

@MarcusSorealheis MarcusSorealheis force-pushed the improve-client-lifecycle-management branch from 81f655c to 4b189f0 Compare November 26, 2025 06:12
}

/// Helper primarily for tests to block until all clients have connected.
pub async fn wait_for_connect_for_testing(&self) -> Result<(), Error> {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

even if this additon solves the problem in your testing @amankrx I will still need to move a few methods in here to the test directory. I put this up to ensure it works so you can test given timezone differences.

@MarcusSorealheis MarcusSorealheis marked this pull request as draft November 27, 2025 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant