MR-1843 Feature : Minimum Swipe Threshold for TP Slider#120
Open
Vrishabhsk wants to merge 3 commits intomasterfrom
Open
MR-1843 Feature : Minimum Swipe Threshold for TP Slider#120Vrishabhsk wants to merge 3 commits intomasterfrom
Vrishabhsk wants to merge 3 commits intomasterfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a minimum swipe threshold feature for the tp-slider component to prevent unintentional swipes on mobile devices. The new min-swipe-threshold attribute allows developers to define a minimum distance required before a swipe gesture is registered, improving UX when users interact with select or input elements within the slider.
Key Changes:
- Added
min-swipe-thresholdattribute with a default value of 0 to maintain backward compatibility - Updated swipe detection logic to require swipe distance to fall within both minimum and maximum thresholds
- Documented the new attribute in the slider README
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/slider/tp-slider.ts | Implements the minimum swipe threshold property and updates swipe detection logic to enforce both minimum and maximum thresholds |
| src/slider/README.md | Documents the new min-swipe-threshold attribute with its default value and purpose |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
junaidbhura
approved these changes
Oct 26, 2025
|
Thanks @Vrishabhsk please test this on a few internal projects before we merge it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Feature
min-swipe-thresholdattribute for thetp-sliderelement0since we don't want to affect the existing behaviourswipe distancefalls between theswipeThresholdandminSwipeThresholdfor left and right swipe, we register it.