-
-
Notifications
You must be signed in to change notification settings - Fork 171
fix(core): add prefix option for primitives #1262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for tresjs-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for tresjs-lab ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for cientos-tresjs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
@tresjs/cientos
@tresjs/core
@tresjs/eslint-config
@tresjs/leches
@tresjs/nuxt
@tresjs/post-processing
commit: |
Tinoooo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I created #1265 to show how I would solve the review threads I created.
…mitives--tino fix(core): add prefix option for primitives
|
@Tinoooo can you help me solve the conflicts with the typescript PR? |
…ion-for-primitives
done ✅ |
Add
primitivePrefixoption for customizable primitive component namesSummary
Adds a new
optionsprop to<TresCanvas>with aprimitivePrefixconfiguration that allows users to customize the primitive component name.Changes
TresCustomRendererOptionsinterface withprimitivePrefixoptionoptionsprop for custom renderer configurationmyprimitivewhen prefix is"my")exportkeyword inGlobalComponents)Usage
TypeScript Support
Users can extend Vue's global components for full intellisense:
Benefits
TRES-186