-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
(feat) Image Gallery/Collection #8210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @lzinga, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request delivers a significant new feature: an interactive Image Gallery/Collection. It allows users to transform any note into a gallery, where they can upload, view, and organize images and nested galleries. The implementation focuses on a smooth user experience with features like infinite scrolling for large collections, robust multi-selection and bulk deletion capabilities, and intuitive image upload with progress feedback. This enhancement greatly improves the application's ability to manage and display visual content. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a new gallery/collection view, which is a significant and well-implemented feature. The implementation includes multi-select, infinite scroll, image uploads, and support for nested galleries. The code is generally clean and follows existing patterns in the application.
I've provided a few suggestions to improve performance by using useMemo for derived data, refactoring some duplicated logic for deletion to improve maintainability, and addressing minor issues like inline styles and hardcoded strings.
Overall, this is a great addition to the project.
…ds with option to share in context menu
|
|
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a new and comprehensive gallery/collection feature. The implementation is well-structured, covering multi-select operations, infinite scrolling, image uploads, and support for nested galleries. The code is generally of high quality. I have identified a couple of areas for improvement, one related to CSS maintainability and a potential bug regarding stale data in gallery cards, for which I've provided suggestions.
…ng in other applications
Adds #7895
To make a gallery all you do is make a new note set the collection type to gallery and you can upload images to it which will create child notes as file type and display them in the gallery. For any child gallery it will show up as a folder type in the parent gallery.
Multi-Select Operations
Infinite Scroll
Image Upload
Nested Galleries
I kept it somewhat light weight to make the possibility of expanding on it in the future easier depending what people may like or dislike about it.
What it looks like in the tree

what it looks like in the note itself.

As note some changes are small eslint updates that kept getting forced. I tried to undo them but eventually thought it would probably be better to keep them.