Fixes 270 - Exclude deps from modules that depend on shaded jar #285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is on hold until the build issues have been resolved. |
|
This is ready to be reviewed at your leisure. |
tjcelaya
approved these changes
Aug 17, 2017
|
@cburroughs I would like your thoughts because this fixes an issue that you reported. |
|
@tjcelaya @cburroughs Shall I go ahead and delete this PR and the associated issue? What are your thoughts? |
indianwhocodes
force-pushed
the
master
branch
from
a997bcb to
b2fb2cd
Compare
indianwhocodes
approved these changes
Apr 8, 2019
indianwhocodes
suggested changes
Apr 11, 2019
| dependency, so it is used in the runtime scope. | ||
| --> | ||
| <dependency> | ||
| <groupId>com.twmacinta</groupId> |
There was a problem hiding this comment.
Change <groupId>com.twmacinta</groupId> to <groupId>com.joyent.util</groupId> here.
There was a problem hiding this comment.
👍 Please commit that change.
There was a problem hiding this comment.
Also, PR #285 hasn't effectively solved the issue and it requires more work.
There was a problem hiding this comment.
A new branch fixes-270 has been created in my forked repository for proactively tracking this issue.
indianwhocodes
force-pushed
the
master
branch
from
c60c737 to
97347c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.