Allow user customization via conf file#6
Open
jflemer-ndp wants to merge 3 commits intoTritonDataCenter:masterfrom
Open
Allow user customization via conf file#6jflemer-ndp wants to merge 3 commits intoTritonDataCenter:masterfrom
jflemer-ndp wants to merge 3 commits intoTritonDataCenter:masterfrom
Conversation
Contributor
|
Hi, Thanks for this. I no longer work on this repo (or at Joyent) but the original intention was to eventually replace it using the approach in https://github.com/joyent/fedora-kvm-image-builder which allows for customization via shell arguments. I guess this could be merged as an interim solution but my expectation is that this repo will probably be replaced at some point. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5.
Adds code to allow optional use of a
create_iso.conffile to override the main options at the top ofcreate_iso. This should be 100% backward compatible if the conf file is not found. If the conf file is found, this should allow much broader use without the need to fork (or edit).