Integrate TrustSignal Verify Artifact in workflow#45
Integrate TrustSignal Verify Artifact in workflow#45chrismaz11 wants to merge 3 commits intomasterfrom
Conversation
Add TrustSignal verification step to workflow
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9aa9ede14b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v4 | ||
| - name: Echo placeholder | ||
| run: echo "Placeholder TrustSignal verify artifact task" |
Check warning
Code scanning / CodeQL
Workflow does not contain permissions Medium
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 3 days ago
In general, the fix is to add an explicit permissions block that grants only the minimum required scopes for GITHUB_TOKEN. For this workflow, the job only checks out the repository and runs a shell command; it does not need write access, so contents: read is sufficient.
The best fix without changing existing functionality is to add a permissions section scoped to the verify-artifact job. This keeps the change minimal and local. At .github/workflows/main.yml, under jobs: verify-artifact:, add:
permissions:
contents: readindented correctly so it is a sibling of runs-on. No imports or additional definitions are needed; this is standard GitHub Actions YAML.
Concretely:
- Edit
.github/workflows/main.yml. - Locate the
verify-artifactjob (lines 9–16). - Insert a
permissionsblock betweenruns-on: ubuntu-latestandsteps:(or equivalently just afterruns-on), at two spaces of indentation underverify-artifact:.
| @@ -8,6 +8,8 @@ | ||
| jobs: | ||
| verify-artifact: | ||
| runs-on: ubuntu-latest | ||
| permissions: | ||
| contents: read | ||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v4 |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ea8cec7692
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - name: Checkout | ||
| uses: actions/checkout@v4 | ||
| - name: Echo placeholder | ||
| run: echo "Placeholder TrustSignal verify artifact task" |
There was a problem hiding this comment.
Replace placeholder step with real artifact verification
The verify-artifact job never performs any verification because its only task is echo "Placeholder TrustSignal verify artifact task", so this workflow will always pass even when the artifact is missing or invalid. In any push/manual run, this makes the new "Verify Artifact" integration non-functional and removes the intended CI/compliance signal.
Useful? React with 👍 / 👎.
Add TrustSignal verification step to workflow
Summary
AI Disclosure
Review Checklist