Clarified staff token method naming

[kevinansfield]

no issue

• "token" is a very overloaded term in our codebase, this is a small step to making our naming more explicit

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 869f49a and 3e298e9.

📒 Files selected for processing (3)

• ghost/core/core/server/api/endpoints/users.js
• ghost/core/core/server/api/endpoints/utils/serializers/output/users.js
• ghost/core/core/server/web/api/endpoints/admin/routes.js

---

Walkthrough

The pull request renames token-related functions and controller properties across multiple files. Specifically, fetchOrCreatePersonalToken() is renamed to fetchOrCreateStaffToken(), and the controller properties readToken and regenerateToken are renamed to readStaffToken and regenerateStaffToken respectively. Corresponding serializer methods and API endpoint routes are updated to use the new names. The signature and functionality of these methods remain unchanged; only the identifiers are updated for consistency.

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'Clarified staff token method naming' directly and specifically describes the main change—renaming token-related methods to be more explicit about their staff token purpose.
Description check	✅ Passed	The description explains that 'token' is overloaded in the codebase and describes the PR as making naming more explicit, which aligns with the actual method renaming changes.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

• 📝 Generate docstrings (stacked PR)
• 📝 Generate docstrings (commit on current branch)

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch rename-staff-token-methods

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}