Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (3)
WalkthroughThis pull request refactors the admin application's file upload handling and updates project dependencies. The koenig-lexical-editor component's custom file upload logic is replaced with external hooks from a dedicated module, reducing code complexity. An import statement is updated to include a 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
2d11a58 to
38086dc
Compare
ref #26626 ghost-admin now imports @tryghost/admin-x-framework/hooks, which resolves via ember-auto-import to dist/hooks.cjs. Ensure build, build:dev, and test run @tryghost/admin-x-framework:build first so dist artifacts exist in CI.
| @@ -1,4 +1,4 @@ | |||
| import isEmail from 'validator/es/lib/isEmail'; | |||
| import isEmail from 'validator/es/lib/isEmail.js'; | |||
There was a problem hiding this comment.
I admit I'm not certain why this is required.
I think this is because validator/es/lib/isEmail isn't directly exported from the validator package, and we need to make sure it's resolving a file.
This change could be done separately, but it only started causing problems after this PR was made.
Let me know if you want me to understand this further.
There was a problem hiding this comment.
Per Claude analysis, it's because Admin uses webpack v5 which uses fullySpecified: true so we need the extension.
closes https://linear.app/ghost/issue/NY-1097 This change should have no user impact. It's just a cleanup.
ref #26626 ghost-admin now imports @tryghost/admin-x-framework/hooks, which resolves via ember-auto-import to dist/hooks.cjs. Ensure build, build:dev, and test run @tryghost/admin-x-framework:build first so dist artifacts exist in CI.
ref https://linear.app/tryghost/issue/NY-1097/ The Ghost admin build resolves this module via webpack's strict ESM rules in CI, which require fully specified deep imports. Adding the .js extension keeps the existing @tryghost/admin-x-framework/hooks usage intact while making CI module resolution deterministic.
This reverts commit a1313d2.
f82bdfa to
9058e15
Compare
closes https://linear.app/ghost/issue/NY-1097
This change should have no user impact. It's just a cleanup.