✨ Added Feedbin to list of supported Inbox Links providers#26641
Merged
✨ Added Feedbin to list of supported Inbox Links providers#26641
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
WalkthroughBumps portal version to 2.65.0. Adds Feedbin as an email provider (provider name 'feedbin', domain 'feedb.in') with static desktop and Android link getters and updates provider resolution. Adds Feedbin icon/label wiring in the portal inbox-link-button component. Adds a unit test for Feedbin handling. Inserts "Open Feedbin" localization keys (empty translations) across many portal locale files. Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
no ref When someone signs up with a [Feedbin] email address, we now have a link to take them straight to the app. (Feedbin is an RSS reader that has custom email inboxes you can use to read everything all in one place.) Note that Feedbin doesn't have an Android app, so we use the regular desktop link for both. [Feedbin]: https://feedbin.com/
EvanHahn
force-pushed
the
feedbin-inbox-link
branch
from
59a1f9f to
18d4d12
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (2)
ghost/i18n/locales/it/portal.json (1)
142-142: Missing Italian translation for "Open Feedbin".The translation value is empty, but following the established pattern in this file (e.g., "Open Gmail" → "Apri Gmail"), the Italian translation would be "Apri Feedbin".
- "Open Feedbin": "", + "Open Feedbin": "Apri Feedbin",🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@ghost/i18n/locales/it/portal.json` at line 142, The "Open Feedbin" translation key has an empty value; update the localization entry for "Open Feedbin" in portal.json to the Italian translation "Apri Feedbin" so it follows the same pattern as keys like "Open Gmail" → "Apri Gmail" (edit the value for the "Open Feedbin" key).ghost/i18n/locales/context.json (1)
192-192: Add translator context for the new Feedbin key.Line 192 is currently blank while adjacent provider keys include guidance; filling it improves translation quality consistency.
♻️ Proposed update
- "Open Feedbin": "", + "Open Feedbin": "Shown on signup and signin if your email is detected as Feedbin",🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@ghost/i18n/locales/context.json` at line 192, The "Open Feedbin" translation entry in ghost/i18n/locales/context.json is missing translator context; update the "Open Feedbin" key to include a descriptive context string similar to adjacent provider keys (e.g., indicate it is a button/link label that opens the user's Feedbin account in a new window or navigates to Feedbin settings) so translators know the intended UI usage and tone. Locate the "Open Feedbin" key and add a concise context note explaining it is an action label for opening the Feedbin provider (e.g., "button label: open user's Feedbin account/settings in external site").
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@ghost/i18n/locales/context.json`:
- Line 192: The "Open Feedbin" translation entry in
ghost/i18n/locales/context.json is missing translator context; update the "Open
Feedbin" key to include a descriptive context string similar to adjacent
provider keys (e.g., indicate it is a button/link label that opens the user's
Feedbin account in a new window or navigates to Feedbin settings) so translators
know the intended UI usage and tone. Locate the "Open Feedbin" key and add a
concise context note explaining it is an action label for opening the Feedbin
provider (e.g., "button label: open user's Feedbin account/settings in external
site").
In `@ghost/i18n/locales/it/portal.json`:
- Line 142: The "Open Feedbin" translation key has an empty value; update the
localization entry for "Open Feedbin" in portal.json to the Italian translation
"Apri Feedbin" so it follows the same pattern as keys like "Open Gmail" → "Apri
Gmail" (edit the value for the "Open Feedbin" key).
ℹ️ Review info
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (68)
apps/portal/package.jsonapps/portal/src/components/common/inbox-link-button.jsghost/core/core/server/lib/get-inbox-links.tsghost/core/core/shared/config/defaults.jsonghost/core/test/unit/server/lib/get-inbox-links.test.tsghost/i18n/locales/af/portal.jsonghost/i18n/locales/ar/portal.jsonghost/i18n/locales/bg/portal.jsonghost/i18n/locales/bn/portal.jsonghost/i18n/locales/bs/portal.jsonghost/i18n/locales/ca/portal.jsonghost/i18n/locales/context.jsonghost/i18n/locales/cs/portal.jsonghost/i18n/locales/da/portal.jsonghost/i18n/locales/de-CH/portal.jsonghost/i18n/locales/de/portal.jsonghost/i18n/locales/el/portal.jsonghost/i18n/locales/en/portal.jsonghost/i18n/locales/eo/portal.jsonghost/i18n/locales/es/portal.jsonghost/i18n/locales/et/portal.jsonghost/i18n/locales/eu/portal.jsonghost/i18n/locales/fa/portal.jsonghost/i18n/locales/fi/portal.jsonghost/i18n/locales/fr/portal.jsonghost/i18n/locales/gd/portal.jsonghost/i18n/locales/he/portal.jsonghost/i18n/locales/hi/portal.jsonghost/i18n/locales/hr/portal.jsonghost/i18n/locales/hu/portal.jsonghost/i18n/locales/id/portal.jsonghost/i18n/locales/is/portal.jsonghost/i18n/locales/it/portal.jsonghost/i18n/locales/ja/portal.jsonghost/i18n/locales/ko/portal.jsonghost/i18n/locales/kz/portal.jsonghost/i18n/locales/lt/portal.jsonghost/i18n/locales/lv/portal.jsonghost/i18n/locales/mk/portal.jsonghost/i18n/locales/mn/portal.jsonghost/i18n/locales/ms/portal.jsonghost/i18n/locales/nb/portal.jsonghost/i18n/locales/ne/portal.jsonghost/i18n/locales/nl/portal.jsonghost/i18n/locales/nn/portal.jsonghost/i18n/locales/pa/portal.jsonghost/i18n/locales/pl/portal.jsonghost/i18n/locales/pt-BR/portal.jsonghost/i18n/locales/pt/portal.jsonghost/i18n/locales/ro/portal.jsonghost/i18n/locales/ru/portal.jsonghost/i18n/locales/si/portal.jsonghost/i18n/locales/sk/portal.jsonghost/i18n/locales/sl/portal.jsonghost/i18n/locales/sq/portal.jsonghost/i18n/locales/sr-Cyrl/portal.jsonghost/i18n/locales/sr/portal.jsonghost/i18n/locales/sv/portal.jsonghost/i18n/locales/sw/portal.jsonghost/i18n/locales/ta/portal.jsonghost/i18n/locales/th/portal.jsonghost/i18n/locales/tr/portal.jsonghost/i18n/locales/uk/portal.jsonghost/i18n/locales/ur/portal.jsonghost/i18n/locales/uz/portal.jsonghost/i18n/locales/vi/portal.jsonghost/i18n/locales/zh-Hant/portal.jsonghost/i18n/locales/zh/portal.json
9larsons
approved these changes
Mar 2, 2026
Contributor
9larsons
left a comment
9larsons
left a comment
There was a problem hiding this comment.
nit: A context.json entry could be helpful.
Co-authored-by: Cathy Sarisky <42299862+cathysarisky@users.noreply.github.com>
cathysarisky
approved these changes
Mar 3, 2026
Member
cathysarisky
left a comment
cathysarisky
left a comment
There was a problem hiding this comment.
Thanks for resolving the context.json issue! I cruise through and try to fill in blanks every so often, but if the folks with the most context fill it out as we go, it ends up better. :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
no ref
When someone signs up with a Feedbin email address, we now have a link to take them straight to the app. (Feedbin is an RSS reader that has custom email inboxes you can use to read everything all in one place.)
Note that Feedbin doesn't have an Android app, so we use the regular desktop link for both.