-
-
Notifications
You must be signed in to change notification settings - Fork 83
Converted url-utils to TypeScript using Claude Code Web #647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
allouis
wants to merge
14
commits into
main
Choose a base branch
from
claude/typescript-url-utils-011CUMXDDvVXejVZdELEuzyZ
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Converted url-utils to TypeScript using Claude Code Web #647
allouis
wants to merge
14
commits into
main
from
claude/typescript-url-utils-011CUMXDDvVXejVZdELEuzyZ
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add tsconfig.json with strict TypeScript configuration - Add TypeScript and type dependencies to package.json - Configure build scripts for TypeScript compilation - Update main entry point to dist/index.js - Add .gitignore for build artifacts 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
- Convert is-ssl.js to TypeScript with proper return type - Convert deduplicate-double-slashes.js to TypeScript - Convert strip-subdirectory-from-path.js to TypeScript - Convert deduplicate-subdirectory.js to TypeScript These are the simplest utility functions with clear inputs and outputs. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
- Convert url-join.js to TypeScript with proper interface - Convert replace-permalink.js with Resource interface - Convert absolute-to-relative.js with options interface - Convert relative-to-absolute.js with options interface - Convert absolute-to-transform-ready.js with options interface Added proper type definitions for all function parameters and return types. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
- Convert relative-to-transform-ready.js to TypeScript - Convert transform-ready-to-absolute.js to TypeScript - Convert transform-ready-to-relative.js to TypeScript - Convert to-transform-ready.js to TypeScript Added proper interfaces for options and type definitions. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
- Convert html-transform.js to TypeScript with proper interfaces - Convert html-relative-to-absolute.js to TypeScript - Convert html-absolute-to-relative.js to TypeScript - Convert html-absolute-to-transform-ready.js to TypeScript - Convert html-relative-to-transform-ready.js to TypeScript - Convert html-to-transform-ready.js to TypeScript Added type definitions for transform functions and options. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
…ript - Convert markdown-transform.js to TypeScript with proper interfaces - Convert markdown-relative-to-absolute.js to TypeScript - Convert markdown-absolute-to-relative.js to TypeScript - Convert markdown-absolute-to-transform-ready.js to TypeScript - Convert markdown-relative-to-transform-ready.js to TypeScript - Convert markdown-to-transform-ready.js to TypeScript Added type definitions for transform functions and remark AST nodes. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Mobiledoc utilities: - Convert mobiledoc-transform.js to TypeScript - Convert mobiledoc-to-transform-ready.js to TypeScript - Convert mobiledoc-relative-to-absolute.js to TypeScript - Convert mobiledoc-absolute-to-relative.js to TypeScript - Convert mobiledoc-relative-to-transform-ready.js to TypeScript - Convert mobiledoc-absolute-to-transform-ready.js to TypeScript Lexical utilities: - Convert lexical-transform.js to TypeScript - Convert lexical-to-transform-ready.js to TypeScript - Convert lexical-relative-to-absolute.js to TypeScript - Convert lexical-absolute-to-relative.js to TypeScript - Convert lexical-relative-to-transform-ready.js to TypeScript - Convert lexical-absolute-to-transform-ready.js to TypeScript Added proper type definitions for transform functions, options interfaces, and JSON structures. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
…cript - Convert plaintext-to-transform-ready.js to TypeScript - Convert plaintext-relative-to-transform-ready.js to TypeScript - Convert plaintext-absolute-to-transform-ready.js to TypeScript Added proper type definitions and interfaces for plaintext URL transformations. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
- Convert lib/utils/index.js to TypeScript - Import all utility functions with proper TypeScript syntax - Export all utilities as a single object 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
…Script - Convert lib/UrlUtils.js to TypeScript with comprehensive type definitions - Add interfaces for UrlUtilsOptions, UrlUtilsConfig, TransformOptions, and UrlForData - Add proper method overloads for methods with optional itemPath parameter - Convert index.js to TypeScript - Maintain full backward compatibility with JavaScript API All public methods now have proper TypeScript signatures and type safety. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
- Fix module imports in UrlUtils.ts to use CommonJS require - Export all option interfaces to allow type naming in declarations - Fix type narrowing issues in functions with overloaded parameters - Add explicit return type to _utils getter - Convert some exports from export= to export default for compatibility - Fix null/undefined handling in optional parameters All TypeScript compilation errors resolved, build succeeds. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
- Add TypeScript parser configuration for .ts files - Disable conflicting ESLint rules for TypeScript - Allows linting to work with both JS and TS files 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Previously the codebase used a mix of `export =` and `export default`.
This standardizes on `export default` throughout for consistency and
better ES6 module compatibility.
Changes:
- Convert all `export = Thing` to `export default Thing`
- Update all imports from `import x = require('./y')` to `import x from './y'`
- Affects 37+ files including all utilities and main classes
All tests passing, build succeeds.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
- Add .eslintignore to exclude dist/ directory from linting - Disable no-dupe-class-members for TypeScript (method overloads) - Disable filename convention rules for TypeScript files These rules were causing CI failures because: 1. TypeScript compiler output in dist/ doesn't follow linting rules 2. TypeScript method overloads are flagged as duplicate class members 3. TypeScript files use different naming conventions than JS files Linting now passes, all tests passing. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prompt 1:
Prompt 2 & 3:
Prompt 4: