Resolves deadlock issues by making synchronous objectForKey: methods truly synchronous#37
Open
rushproject wants to merge 3 commits intoTumblrArchive:masterfrom
Open
Resolves deadlock issues by making synchronous objectForKey: methods truly synchronous#37rushproject wants to merge 3 commits intoTumblrArchive:masterfrom
rushproject wants to merge 3 commits intoTumblrArchive:masterfrom
Conversation
Re-implements synchronous objectForKey as true synchronous methods. See http://stackoverflow.com/questions/19306934/trouble-with-dispatch-semaphore-wait-on-some-devices/19325192#19325192 for discussion.
… objectForKey: counterparts
…ject initializations
dherberger
pushed a commit
to vertigo/TMCache
that referenced
this pull request
Apr 10, 2014
… their respective forks
Contributor
|
This PR may have a better solution for this problem: #71 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also refactors async objectForKey:block: to use synchronous objectForKey: counterparts. Speed improvements by reducing number of dispatched threads, dropping unnecessary calls, postponing object instantiation.