Change script engine to use Sol2 instead of LuaBridge #3
Conversation
…unning out of memory despite the system having more than sufficient free memory.
addictgamer
changed the title
addictgamer
changed the title
SheridanR
left a comment
SheridanR
left a comment
There was a problem hiding this comment.
Really impressive changes! I'd much prefer if sol.hpp could go in GameLibs though because it's just a dependency, not original code. We should probably change from using a GameLibs.zip to an external libs folder of some kind (next to the src folder)
| } | ||
|
|
||
| //These functions are not in the script.cpp file since they drastically increase compile time and memory usage due to heavy template usage. | ||
| void Script::exposeBBox() { |
There was a problem hiding this comment.
This is fine for a first pass but if these expose functions could be members of their respective classes (ie BBox::exposeToScript() instead of Script::exposeBBox()) it would be way better.
| void setPressed(const bool _pressed) { reallyPressed = _pressed; } | ||
|
|
||
| template<typename T> | ||
| void addParam(T param) |
There was a problem hiding this comment.
This is way better, kudos.
We can do that, I was honestly just too lazy to add it to CMake ;P |
Signed-off-by: SheridanR <sheridan.rathbun@gmail.com>
Conflicts: src/Entity.cpp vs.2017/spacepunk/spacepunk.vcxproj
Signed-off-by: SheridanR <sheridan.rathbun@gmail.com>
SheridanR
force-pushed
the
master
branch
2 times, most recently
from
d0659e9 to
3d3cfe6
Compare
No description provided.