Conversation
Signed-off-by: Reece Hagan <drogonmar@tuyuji.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses Task Renderer: MSAA support
Parent pass now contain a primary render target with MSAA enabled that child passes render to.
The current way the parent clears the primary render target feels a bit jank but no idea of alternatives currently.
There's no support right now to select the level of MSAA to use, I think disabling MSAA isn't really necessary as the performance benefit probably isn't major and you end up making rounded corners look awful.
General state of flow:
flowchart TD Start([Start Parent Pass]) --> Clear[1. Clear MSAA RT] Clear --> Children[2. For Each Child Pass:<br/>Render to MSAA RT] Children --> Resolve[3. MSAA Resolve Pass] Resolve --> ResolvedUI[Resolved UI RT] ColorInputOutput[ColorInputOutput] --> Composite ResolvedUI --> Composite[4. Composite Pass<br/>ColorInputOutput + UI] Composite --> Output([Parent Pass ColorInputOutput]) style Clear fill:#fdd,stroke:#333 style Children fill:#ffd,stroke:#333 style Resolve fill:#ddf,stroke:#333 style Composite fill:#dfd,stroke:#333 style Output fill:#bfb,stroke:#333