Skip to content

Remove sanitization method and related calls from Pattern_Builder_API #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pbking wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove sanitization method and related calls from Pattern_Builder_API #43

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
72 changes: 0 additions & 72 deletions includes/class-pattern-builder-api.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -406,9 +406,6 @@ function handle_hijack_block_update( $response, $handler, $request ) {
);
}

// Sanitize the input data
$updated_pattern = $this->sanitize_pattern_input( $updated_pattern );

$convert_user_pattern_to_theme_pattern = false;

if ( $post->post_type === 'wp_block' ) {
Expand Down Expand Up @@ -499,73 +496,6 @@ function handle_hijack_block_update( $response, $handler, $request ) {
return $response;
}

/**
* Sanitizes pattern input data to prevent XSS and ensure data integrity.
*
* @param array $input The input data to sanitize.
* @return array Sanitized input data.
*/
private function sanitize_pattern_input( $input ) {
if ( ! is_array( $input ) ) {
return array();
}

$sanitized = array();

// Sanitize text fields
if ( isset( $input['title'] ) ) {
$sanitized['title'] = sanitize_text_field( $input['title'] );
}

if ( isset( $input['excerpt'] ) ) {
$sanitized['excerpt'] = sanitize_textarea_field( $input['excerpt'] );
}

// Sanitize content - allow HTML but sanitize it
if ( isset( $input['content'] ) ) {
$sanitized['content'] = wp_kses_post( $input['content'] );
}

// Sanitize source field
if ( isset( $input['source'] ) ) {
$sanitized['source'] = in_array( $input['source'], array( 'theme', 'user' ), true ) ? $input['source'] : 'user';
}

// Sanitize sync status
if ( isset( $input['wp_pattern_sync_status'] ) ) {
$sanitized['wp_pattern_sync_status'] = in_array( $input['wp_pattern_sync_status'], array( 'synced', 'unsynced' ), true ) ? $input['wp_pattern_sync_status'] : 'unsynced';
}

// Sanitize inserter setting
if ( isset( $input['wp_pattern_inserter'] ) ) {
$sanitized['wp_pattern_inserter'] = in_array( $input['wp_pattern_inserter'], array( 'yes', 'no' ), true ) ? $input['wp_pattern_inserter'] : 'yes';
}

// Sanitize array fields
$array_fields = array( 'wp_pattern_block_types', 'wp_pattern_post_types', 'wp_pattern_template_types' );
foreach ( $array_fields as $field ) {
if ( isset( $input[ $field ] ) ) {
if ( is_array( $input[ $field ] ) ) {
$sanitized[ $field ] = array_map( 'sanitize_text_field', $input[ $field ] );
} elseif ( is_string( $input[ $field ] ) ) {
// Handle comma-separated strings
$values = explode( ',', $input[ $field ] );
$sanitized[ $field ] = array_map( 'sanitize_text_field', $values );
}
}
}

// Pass through other fields that don't need sanitization but need to be preserved
$passthrough_fields = array( 'id', 'date', 'date_gmt', 'modified', 'modified_gmt', 'status', 'type' );
foreach ( $passthrough_fields as $field ) {
if ( isset( $input[ $field ] ) ) {
$sanitized[ $field ] = $input[ $field ];
}
}

return $sanitized;
}

/**
* When anything is saved any wp:block that references a theme pattern is converted to a wp:pattern block instead.
*
Expand All @@ -584,8 +514,6 @@ public function handle_block_to_pattern_conversion( $response, $handler, $reques
return $response; // Return original response if JSON is invalid
}

// Sanitize the input data
$body = $this->sanitize_pattern_input( $body );
if ( isset( $body['content'] ) ) {
// parse the content string into blocks
$blocks = parse_blocks( $body['content'] );
Expand Down