Skip to content

Fix & enhancements #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix & enhancements #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
510ec85
Fix order of initialization
Aug 6, 2020
59dbdf6
Add extra params on response from verify()
Aug 6, 2020
d1902bc
Update version
Aug 6, 2020
24b1c24
Update returned api params
Aug 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "typingdnaclient",
"version": "1.0.5",
"version": "1.0.6",
"description": "Basic nodeJs implementation for the TypingDNA.com Auth API",
"main": "typingdnaclient.js",
"scripts": {
Expand Down
21 changes: 15 additions & 6 deletions typingdnaclient.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/**
* NodeJs implementation for the TypingDNA.com Auth API.
*
* @version 1.0.5
* @version 1.0.6
*
* @author Stefan Endres
* @copyright TypingDNA.com, SC TypingDNA SRL
Expand Down Expand Up @@ -87,13 +87,16 @@ TypingDNAClient.prototype.save = function(userId, typingPattern, callback) {
}
callback && callback(error, {
message: response['message'],
message_code: response['message_code'],
success: response['success'] || 0,
statusCode: parseInt(response['status'])
});
})
};

/**
* TODO Update doc
*
* Check user method for verifying how many previous recordings you have for a user
* Usage: typingDnaClient.check(userData, callback);
*
Expand Down Expand Up @@ -141,6 +144,7 @@ TypingDNAClient.prototype.check = function(options, callback) {
}
callback && callback(error, {
message: response['message'],
message_code: response['message_code'],
success: response['success'] || 0,
count: response['count'],
mobilecount: response['mobilecount'],
Expand Down Expand Up @@ -195,6 +199,7 @@ TypingDNAClient.prototype.delete = function(options, callback) {
}
callback && callback(error, {
message: response['message'],
message_code: response['message_code'],
success: response['success'] || 0,
result: response['deleted'],
statusCode: parseInt(response['status'])
Expand All @@ -215,6 +220,10 @@ TypingDNAClient.prototype.delete = function(options, callback) {
**/

TypingDNAClient.prototype.verify = function(userId, typingPattern, quality, options, callback) {
if(typeof options === 'function') {
callback = options;
options = {}
}
if(typeof userId !== 'string' || userId.replace(/\s/g,'').length < 6) {
return callback && callback(new Error('Invalid user id.'), null);
}
Expand All @@ -224,10 +233,6 @@ TypingDNAClient.prototype.verify = function(userId, typingPattern, quality, opti
if(typeof quality !== 'number') {
quality = 2;
}
if(typeof options === 'function') {
callback = options;
options = {}
}

this.makeRequest({
path: '/verify/'+ encodeURIComponent(userId),
Expand All @@ -243,6 +248,7 @@ TypingDNAClient.prototype.verify = function(userId, typingPattern, quality, opti
}
var resObj = {
message: response['message'],
message_code: parseInt(response['message_code']),
success: response['success'] || 0,
statusCode: parseInt(response['status'])
}
Expand All @@ -252,7 +258,9 @@ TypingDNAClient.prototype.verify = function(userId, typingPattern, quality, opti
if(response['device_similarity'] !== undefined) { resObj['deviceSimilarity'] = Math.round(response['device_similarity']); }
if(response['confidence_interval'] !== undefined) { resObj['confidence'] = Math.round(response['confidence_interval']); }
if(response['confidence'] !== undefined) { resObj['netConfidence'] = Math.round(response['confidence']); }

if(response['positions'] !== undefined) { resObj['positions'] = response['positions']; }
if(response['previous_samples'] !== undefined) { resObj['previous_samples'] = response['previous_samples']; }
if(response['compared_samples'] !== undefined) { resObj['compared_samples'] = response['compared_samples']; }
callback && callback(error, resObj);
})
};
Expand Down Expand Up @@ -300,6 +308,7 @@ TypingDNAClient.prototype.match = function(typingPattern1, typingPattern2, quali
}
var resObj = {
message: response['message'],
message_code: response['message_code'],
success: response['success'] || 0,
statusCode: parseInt(response['status'])
}
Expand Down