Port all simulated c++ tests to python#3632
Draft
nycrat wants to merge 74 commits intoUBC-Thunderbots:masterfrom
Draft
Port all simulated c++ tests to python#3632nycrat wants to merge 74 commits intoUBC-Thunderbots:masterfrom
nycrat wants to merge 74 commits intoUBC-Thunderbots:masterfrom
Conversation
…port_simulated_cpp_tests_to_python
nycrat
force-pushed
the
avah/port_simulated_cpp_tests_to_python
branch
from
6e9ac69 to
674d985
Compare
nycrat
force-pushed
the
avah/port_simulated_cpp_tests_to_python
branch
from
674d985 to
f1dbcde
Compare
nycrat
changed the title
nycrat
requested review from
Andrewyx,
sauravbanna and
williamckha
as code owners
nycrat
changed the title
Member
Author
|
actually, i'll try to break this pr apart to make it easier to review |
…_cpp_tests_to_python
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(PART 3)
Description
This PR ports all existing simulated gameplay c++ tests to python (while keeping original pytests), and also refactoring python gameplay tests to be easier to create and maintain
Ported Tests
Found using:
rg SimulatedErForceSimPlayTestFixtureand manual sortingTACTIC TESTS TO PORT
PLAY TESTS TO PORT
KickoffEnemyPlayand convert it to an FSM #3296)KickoffEnemyPlayand convert it to an FSM #3296)Resolved Issues
resolves #2558, resolves #2778
Length Justification and Key Files to Review
Porting tests requires lots of changes, plus the changes in the syntax used for set_tactics and moving pytest validations to its own directory requires updating every python test file anyways.
Review Checklist
It is the reviewers responsibility to also make sure every item here has been covered
.hfile) should have a javadoc style comment at the start of them. For examples, see the functions defined inthunderbots/software/geom. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.TODO(or similar) statements should either be completed or associated with a github issue