Skip to content

Move pytest validations to its own directory#3639

Open
nycrat wants to merge 5 commits intoUBC-Thunderbots:masterfrom
nycrat:avah/move_pytests_to_own_directory
Open

Move pytest validations to its own directory#3639
nycrat wants to merge 5 commits intoUBC-Thunderbots:masterfrom
nycrat:avah/move_pytests_to_own_directory

Conversation

@nycrat
Copy link
Member

@nycrat nycrat commented Mar 8, 2026

(PART 1)

Description

  • Moves pytest validations from simulated_tests/ to simulated_tests/pytest_validations/
  • Creates RobotAtPosition, RobotAtOrientation, RobotAtAngularVelocity, DelayValidation for future tests
  • Remove ball BallMovesFromRest and BallMovesForward in favour of using other existing validations

Testing Done

Resolved Issues

part of #2558

Length Justification and Key Files to Review

Review Checklist

It is the reviewers responsibility to also make sure every item here has been covered

  • Function & Class comments: All function definitions (usually in the .h file) should have a javadoc style comment at the start of them. For examples, see the functions defined in thunderbots/software/geom. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.
  • Remove all commented out code
  • Remove extra print statements: for example, those just used for testing
  • Resolve all TODO's: All TODO (or similar) statements should either be completed or associated with a github issue

@nycrat nycrat force-pushed the avah/move_pytests_to_own_directory branch from 8061515 to 070e2f8 Compare March 8, 2026 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant