Skip to content

Change simulated test runner set_tactics() syntax#3640

Draft
nycrat wants to merge 7 commits intoUBC-Thunderbots:masterfrom
nycrat:avah/change_set_tactic_syntax
Draft

Change simulated test runner set_tactics() syntax#3640
nycrat wants to merge 7 commits intoUBC-Thunderbots:masterfrom
nycrat:avah/change_set_tactic_syntax

Conversation

@nycrat
Copy link
Member

@nycrat nycrat commented Mar 8, 2026

(PART 2)

Description

Testing Done

Resolved Issues

Length Justification and Key Files to Review

Review Checklist

It is the reviewers responsibility to also make sure every item here has been covered

  • Function & Class comments: All function definitions (usually in the .h file) should have a javadoc style comment at the start of them. For examples, see the functions defined in thunderbots/software/geom. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.
  • Remove all commented out code
  • Remove extra print statements: for example, those just used for testing
  • Resolve all TODO's: All TODO (or similar) statements should either be completed or associated with a github issue

@nycrat nycrat marked this pull request as draft March 8, 2026 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant