Merged
Conversation
swhelan123
reviewed
Apr 13, 2026
Member
swhelan123
left a comment
swhelan123
left a comment
There was a problem hiding this comment.
i know this is just an OOPified version of the existing nextion code, but you have creative freedom here if you see any possible improvements that can be made
think how things could be set up so minimal code changes are required if the dash setup changes and if more pages are added or different types of components are added to pages
have a flick through the nextion editor to get a feel for what's available.
Contributor
Author
|
Just did short ints cause god help us if any of those values hit 32k |
swhelan123
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made static Nextion class instead of just a namespace for access modifiers. The logic for nextion methods more or less copied from prototype, except privatised sendCmd for safety and used string safe methods.
Made a struct DashStatus with the dash information to move away from using globals for all the metrics. Instead a dashStatus struct is passed into updateDash. This gives us freedom to either use a global/static dashStatus struct for CAN telemetry or make a struct out of the metrics each time.
@swhelan123