Skip to content

Updated LapController with button triggered lap logic. #298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alexwhelan12 wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Updated LapController with button triggered lap logic. #298

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
320f3ea
Updated LapController with button triggered lap logic.
alexwhelan12 Mar 14, 2026
82e9072
Remove uneeded functions
alexwhelan12 Mar 14, 2026
f7b4c4a
Addressed code rabbit changes
alexwhelan12 Mar 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 34 additions & 5 deletions packages/server/src/controllers/LapController/LapController.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ import type {
} from "@shared/helios-types";

const logger = createLightweightApplicationLogger("LapController.ts");
const MIN_PACKETS_FOR_LAP = 5;
/**
*
* There is some general documentation on this file in the docs, but it is not very detailed
Expand All @@ -39,6 +40,7 @@ const logger = createLightweightApplicationLogger("LapController.ts");
*/
export class LapController implements LapControllerType {
public lastLapPackets: ITelemetryData[] = [] as ITelemetryData[];
public previousLapDigital: boolean | null = null;
public previouslyInFinishLineProximity = false;
public passedDebouncedCheckpoint = false;
public totalTime = 3600 * 1000 * 8; // 1000 ms/sec * 3600 sec/hr * 8 hr
Expand Down Expand Up @@ -170,6 +172,10 @@ export class LapController implements LapControllerType {
}

public async handlePacket(packet: ITelemetryData) {
// Always buffer packets so a lap boundary has data available for calculations.
// NOTE: The lastLapPackets will grow indefinitely if LapDigital is never triggered.
Copy link
Collaborator

@justin-phxm justin-phxm Mar 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 * 60 * 60 = 7200.

Set a maximum array size of 7200 to avoid memory overflows.

this.lastLapPackets.push(packet);

const motorDetails0 = packet.MotorDetails0.VehicleVelocity;
const motorDetails1 = packet.MotorDetails1.VehicleVelocity;
if (this.raceInfo.raceDay >= 3)
Expand All @@ -185,15 +191,37 @@ export class LapController implements LapControllerType {
this.calculateRaceDistance(motorDetails0, motorDetails1);
}

if (this.checkLap(packet) && this.lastLapPackets.length > 5) {
logger.info("lap completed for geofence");
const lapDigital = Boolean(packet.B3.LapDigital);

// Single source of truth for LapDigital-triggered laps:
// only fire on a false -> true transition after we have a previous sample.
const canInsertLapFromDigital =
this.previousLapDigital !== null &&
this.previousLapDigital === false &&
lapDigital === true;

// Update state for next packet.
this.previousLapDigital = lapDigital;

if (lapDigital) {
// logger.info("lap completed for geofence");
logger.info("LapDigital is true, lap completed.");
}

if (
// TEST: The condition was commented out because, in the current fakePacket data, packet.B3.LapDigital is always false. As a result, the code for broadcasting lap data (broadcastLapData) would never execute during testing with fakePacket. By commenting out this condition, it allows the code to proceed and broadcast lap data even when LapDigital is false.
// packet.B3.LapDigital &&
this.lastLapPackets.length > 5
// this.lastLapPackets.length > 5
canInsertLapFromDigital
) {
if (this.lastLapPackets.length < MIN_PACKETS_FOR_LAP) {
logger.warn(
`Ignoring lap boundary: only ${this.lastLapPackets.length} packet(s) buffered, need at least ${MIN_PACKETS_FOR_LAP}.`,
);
this.backendController.socketIO.broadcastRaceInfo(this.raceInfo);
return;
}

await this.backendController.socketIO.broadcastLapComplete();
// mark lap, calculate lap, and add to lap table in database
// send lap over socket
Expand All @@ -210,8 +238,8 @@ export class LapController implements LapControllerType {
AveragePackCurrent: averagePackCurrent,
AverageSpeed: this.calculateAverageLapSpeed(this.lastLapPackets),
BatterySecondsRemaining: this.getSecondsRemainingUntilChargedOrDepleted(
amphoursValue,
averagePackCurrent,
amphoursValue,
),
Distance: this.getDistanceTravelled(this.lastLapPackets), // CHANGE THIS BASED ON ODOMETER/MOTOR INDEX OR CHANGE TO ITERATE
EnergyConsumed: this.getEnergyConsumption(this.lastLapPackets),
Expand All @@ -224,11 +252,11 @@ export class LapController implements LapControllerType {
};

this.handleLapData(lapData);
this.raceInfo.lapNumber += 1;
this.lastLapPackets = [];
}

this.backendController.socketIO.broadcastRaceInfo(this.raceInfo);
this.lastLapPackets.push(packet);
}

public getLastPacket(): ITelemetryData[] {
Expand All @@ -251,6 +279,7 @@ export class LapController implements LapControllerType {
}

// checks if lap has been acheived (using geofencing)
// if geofence approach is used, use this function to check if lap has been completed instead of using LapDigital
private checkLap(packet: ITelemetryData) {
const inProximity =
haversineDistance(
Expand Down
Loading