Skip to content

Conversation

@ellendejong
Copy link
Collaborator

@ellendejong ellendejong commented Sep 17, 2024

What has changed?

  • Added Github workflow actions per tool.
    By using path filters, a wokflow runs based on what file paths are changed.
  • Use pytest-datadir to group test data together in GenderCheck and MosaicHunter. Pytest-datadir will detect dir with the name of your module (used in this PR) or global name 'data'.
  • Lint updates in Util scripts.

Copy link
Member

@rernst rernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ziet er goed uit, wat kleine implementatie opmerkingen / vragen.

@ellendejong ellendejong requested a review from rernst September 27, 2024 09:57
Copy link
Member

@rernst rernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nog 1 laatste opmerking over paths bij 'on' config van github actions.

@ellendejong ellendejong requested a review from rernst September 30, 2024 06:15
rernst
rernst previously approved these changes Sep 30, 2024
@rernst rernst self-requested a review November 4, 2024 07:25
rernst
rernst previously approved these changes Nov 4, 2024
@rernst rernst self-requested a review November 4, 2024 09:45
rernst
rernst previously approved these changes Nov 4, 2024
Copy link
Member

@rernst rernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, cache works :)

@ellendejong ellendejong merged commit 3047676 into develop Nov 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants