Remove BaseTmethod parameter and always use weekday/weekend base temperatures #749
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removes the obsolete
BaseTmethodparameter from the Fortran codebase and simplifies heating/cooling degree day (HDD/CDD) calculations to always use weekday/weekend-specific base temperatures.Context
BaseTmethodwas a legacy parameter that controlled whether to use:BaseT_HCvalue for both heating and coolingBaseT_HeatingandBaseT_CoolingarraysSince
BaseT_HCwas removed from input files in SUEWS v2023a, Method 1 became non-functional. The Fortran code hadBaseTmethodhardcoded to 2 (always use Method 2), making it dead code.Changes
Fortran Code
suews_ctrl_const.f95: RemovedBaseTMethodvariable declarationsuews_phys_dailystate.f95:BaseTMethodandBaseT_HCparametersupdate_DailyState_Daysubroutine signatureBaseT_Heating(iu)andBaseT_Cooling(iu)based on weekday/weekendCode Simplification
Impact
User-Facing
✅ No breaking changes
basetmethodwas already removed from user-facing configuration in v2023BaseTmethodInternal
Clarification: BaseT vs BaseTe
This change does NOT affect
BaseTandBaseTe, which are separate vegetation parameters for:These remain unchanged and are unrelated to anthropogenic heat flux calculations.
Testing
Fixes #144