Fix: building_archetype nullified when stebbsmethod == 0

[dayantur]

While addressing #851 , I noticed ArchetypeProperties params were not nullified in phase_b.py when stebbsmethod ==0.
When stebbsmethod ==0, both stebbs and building_archetype params must be set to null.

This PR also edits all ArchetypeProperties Pydantic fields to become Optional (allowing for null values).

[github-actions]

🔍 Schema Preview Deployed

Preview URLs:

• 🆕 Preview schemas: https://umep-dev.github.io/SUEWS/preview/pr-958/schemas/suews-config/
• 📋 Preview landing: https://umep-dev.github.io/SUEWS/preview/pr-958/

Production URLs (unchanged):

• ✅ Production schemas: https://umep-dev.github.io/SUEWS/schemas/suews-config/
• 🏠 Production landing: https://umep-dev.github.io/SUEWS/

---

⚠️ Important: Preview schemas are in a subdirectory and do not affect production. The preview pages include warning banners to prevent accidental use in production configs.

[sunt05]

PR Review Summary

Overall Assessment: ✅ Approve with minor suggestions

Category	Status	Notes
Code Logic	✅ PASS	Correctly fixes the nullification gap
Code Style	✅ PASS	Follows SUEWS conventions
Type Safety	✅ PASS	Optional types properly applied
CI/Build	✅ PASS	All checks passing
Documentation	⚠️ MINOR	CHANGELOG entry missing PR reference
Test Coverage	⚠️ MINOR	No test for building_archetype nullification

Key Findings

✅ What's Good

1. Core fix is correct: When stebbsmethod == 0, both stebbs and building_archetype blocks should be nullified. The fix properly addresses this by iterating over both block names.

2. Improved robustness: The refactored _nullify_block helper now handles lists in addition to dicts, which is more defensive against unexpected data structures.

3. Clean refactoring: The nested function _nullify_block improves code readability and reduces duplication compared to the original inline logic.

4. Optional types are appropriate: Making ArchetypeProperties fields Optional allows them to accept None values, which is necessary for the nullification logic to work correctly.

⚠️ Minor Suggestions

1. CHANGELOG: Add PR number (#958) for traceability. (see line comment)

2. Test coverage: The existing test test_stebbsmethod0_nullifies_all_stebbs_values() only tests stebbs block. Consider adding a companion test for building_archetype:

def test_stebbsmethod0_nullifies_building_archetype_values():
    yaml_input = {
        "model": {"physics": {"stebbsmethod": {"value": 0}}},
        "sites": [{"properties": {
            "building_archetype": {
                "BuildingType": {"value": "SampleType"},
                "stebbs_Height": {"value": 10.0},
            }
        }}],
    }
    result = precheck_model_option_rules(deepcopy(yaml_input))
    out = result["sites"][0]["properties"]["building_archetype"]
    assert out["BuildingType"]["value"] is None
    assert out["stebbs_Height"]["value"] is None

Suggested Reviewers

• @yiqing1021 (module:stebbs)

---

1 line comment posted for specific issues

🤖 Generated with Claude Code

[sunt05]

See inline comment on CHANGELOG.md

[github-actions]

Documentation Preview

Preview URL: https://umep-dev.github.io/SUEWS/preview/pr-958/docs/

This is a PR preview. Production docs remain at https://suews.readthedocs.io

[github-actions]

🤖 I've automatically formatted the code in this PR using:

• Python: ruff v0.8.6
• Fortran: fprettify v0.3.7

Please pull the latest changes before making further edits.

[dayantur]

Hi @sunt05 - test added & changelog PR specification included :)
hi @yiqing1021 - can you give a thumb up as well if everything looks fine?