BasilIR.cf update from obasil: phi, var load/store, named params#591
Open
katrinafyi wants to merge 15 commits intomainfrom
Open
BasilIR.cf update from obasil: phi, var load/store, named params#591katrinafyi wants to merge 15 commits intomainfrom
katrinafyi wants to merge 15 commits intomainfrom
Conversation
This reverts commit 1cd5318.
Member
Author
|
ci failing is definitely a line ending problem |
Contributor
I would prefer round brackets, square brackets are used to give the impression of a sequence of nonatomic operations, phis don't have evaluation order etc it seems odd, the phi list is semantically the same as a simulassign and i wanted the syntax to point to that. Instead the ambiguity could be fixed by moving the phi list before the block's statement list, this gives the impression of block parameters which I don't hate. |
agle
reviewed
Jan 22, 2026
| assign | ||
| } | ||
|
|
||
| simulAssign.assignments :+= (phiVar -> predVar) |
Member
Author
|
you want this? any suggestions for the indentation? or maybe |
Contributor
|
The first option, indentation can be the same as it already is. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
compared to obasil, changes the phi block syntax to use square brackets to avoid ambiguity with simulassign statement.
see src/test/scala/ir/ParserTest.scala to learn the effect of phi blocks and named call params. these get lowered into sbasil simul assigns and unnamed params.