CDA-56 - Enhance exception handling to include detailed error message #1546
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamkorynta
requested changes
Jan 22, 2026
| }) | ||
| .exception(Exception.class, (e, ctx) -> { | ||
| CdaError errResponse = new CdaError("System Error"); | ||
| CdaError errResponse = new CdaError("System Error", Map.of("Error message", e.getMessage())); |
Collaborator
There was a problem hiding this comment.
This will escape unexpected oracle stack traces. Should trap specific exceptions, see https://github.com/USACE/cwms-data-api/blob/develop/cwms-data-api/src/main/java/cwms/cda/data/dao/RateDao.java#L169
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1287
This provides additional details to the error message so there's less guessing about the issue.