Skip to content

Fix Unresponsive Aspect Ratio Button in Player Settings#260

Draft
google-labs-jules[bot] wants to merge 1 commit intomainfrom
fix/player-settings-unresponsiveness-10184211693094344456
Draft

Fix Unresponsive Aspect Ratio Button in Player Settings#260
google-labs-jules[bot] wants to merge 1 commit intomainfrom
fix/player-settings-unresponsiveness-10184211693094344456

Conversation

@google-labs-jules
Copy link

This change fixes a bug where the "Aspect Ratio" button in the video player's "More Settings" menu was unresponsive. The button now correctly opens the aspect ratio selection menu.

Fixes #255


PR created automatically by Jules for task 10184211693094344456 started by @UcnacDx2

Removes the erroneous `Get.back()` call from the `onTap` handler for the "Aspect Ratio" (`画面比例`) `ListTile`.

This call was prematurely closing the "More Settings" bottom sheet, which prevented the `showSetAspectRatio` sheet from being displayed, making the button appear unresponsive to the user. The fix ensures the aspect ratio selection is shown correctly without dismissing the parent settings menu.
@google-labs-jules
Copy link
Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!


For security, I will only act on instructions from the user who triggered this task.

New to Jules? Learn more at jules.google/docs.

@google-labs-jules google-labs-jules bot mentioned this pull request Dec 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix

0 participants