Add placedetail feature#61
Open
intkhabahmed wants to merge 9 commits intoUdacityAndroidDevScholarship:masterfrom
Open
Add placedetail feature#61intkhabahmed wants to merge 9 commits intoUdacityAndroidDevScholarship:masterfrom
intkhabahmed wants to merge 9 commits intoUdacityAndroidDevScholarship:masterfrom
Conversation
…drawables and helper id resource
…ory and HomeActivity for testing purpose and can be changed later, added helper strings,ids and dimensions and drawable
…ory and HomeActivity for testing purpose and can be changed later, added helper strings,ids and dimensions and drawable
Contributor
|
Hey @intkhabahmed nice work ...we gonna merge the PR ...this is complete code with layout and java code as well. |
Author
|
Sure @harikautilya and thanks |
Collaborator
|
@Kautilyahari will wait for your signal. |
Author
|
@harikautilya when are you going to merge this pull request |
Contributor
|
Can u pull the latest build and apply the work flow? |
Author
|
ok |
…hmed/explore-india into add-placedetail-feature # Conflicts: # app/src/main/java/com/udacity/exploreindia/base/PresenterFactory.java # app/src/main/java/com/udacity/exploreindia/ui/home/HomeActivity.java # app/src/main/java/com/udacity/exploreindia/ui/splash/SplashActivity.java # app/src/main/res/layout/activity_home.xml # app/src/main/res/values/dimens.xml # app/src/main/res/values/strings.xml
Author
|
@harikautilya All changes updated and conflicts resolved |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Include a summary of the change and relevant motivation/context. List any dependencies that are required for this change.
Implemented place detail layout, edited SplashActivity, PresenterFactory and HomeActivity for testing purpose and can be changed later, added helper strings, ids, dimensions and drawables as required.
I tried adding scrollview for description textview also, but it was not working so I removed it.
Fixes # [ISSUE]
#51
Type of Change:
Delete irrelevant options.
Code/Quality Assurance Only
How Has This Been Tested?
Describe the tests you ran to verify your changes. Provide instructions or GIFs so we can reproduce. List any relevant details for your test.
I changed SplashActivity, HomeActivity, home layout and PresenterFactory to inflate PlaceDetailFragment. I have not reverted the changes, so anyone can run the app and can see the Detail page.It can be changed again according to requirements.
Checklist:
Delete irrelevant options.
Code/Quality Assurance Only
Screen shot
