Selected State With City Screen#96
Open
arunkbabu90 wants to merge 6 commits intoUdacityAndroidDevScholarship:masterfrom
Open
Selected State With City Screen#96arunkbabu90 wants to merge 6 commits intoUdacityAndroidDevScholarship:masterfrom
arunkbabu90 wants to merge 6 commits intoUdacityAndroidDevScholarship:masterfrom
Conversation
Collaborator
|
Please resolved merge conflicts and and a screentshot of your layout. |
Author
|
I've resolved all the merge conflicts @Rondaul. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fully Implemented SelectedStatesActivity which now includes both City and Places screens in one TabLayout activity.
Note that this PR is an extension of @ibhavikmakwana 's issue #78 which only has the Places screen.
Also note that this activity is not connected any screens right now; so you need to manually create an intent to launch the *SelectedStatesActivity.java in-order to view this activity
IMPORTANT: Firstly merge the PR of Issue #78 & then merge this PR
Fixes #79
Type of Change:
How Has This Been Tested?
I tested this on Android Studio's Emulator and on my Physical Device. Since this activity is not linked to any other items/screens right now. I verified the changes by creating an intent manually in the LogOut menu's item-selected-event in the HomeActivity. This intent is now deleted from LogOut menu to maintain its original functionality, so to view this activity again you need the create an intent manually
Checklist: