Alert Dialog When the Data/WIFI is Off in Quiz App.#165
Open
animeshroydev wants to merge 2 commits intoUdacityAndroidDevScholarship:developmentfrom
Open
Alert Dialog When the Data/WIFI is Off in Quiz App.#165animeshroydev wants to merge 2 commits intoUdacityAndroidDevScholarship:developmentfrom
animeshroydev wants to merge 2 commits intoUdacityAndroidDevScholarship:developmentfrom
Conversation
drulabs
reviewed
May 17, 2018
Collaborator
There was a problem hiding this comment.
@animeshroydev it is a good user experience to show an alert dialog that directly takes the user to network or wifi settings. Thanks for the suggestion. Here are a few things that need attention:
- There is a
utils/Connectivityclass, the isConnected method in HomeActivity can be moved there with a different name likeisDataOrWifiConnected - The negative and positive button on alert dialog should be swapped I think.
- Where ever possible convert single method anonymous interfaces instances into lambdas.
- Also please remove hard-coded strings.
The rest looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alert Dialog added if there is no internet connection in the QUIZ App.
Initially if the internet connection is off in the quiz app there is no Alert Dialog pops up. For attempting quiz, internet connection is needed but in the quiz app there are already some quizes that loads up previously(when the internet was connected) but if the user not connected then there was no alert dialog pops up. I have included this features so that the user know about it that he/she need to connect with data/wifi.
Screenshots
BEFORE:

AFTER:

I know it's just a simple feature but it will make a good user expreience. So please leave your feedback on it... @drulabs @CoderVishalSehgal @aditisoni8899