Implement loading overhaul #1029
Conversation
1. Allow it to load partial data if it encounters an error while loading. This would normally result in the entire game being inaccessible. Saving is disabled in this mode, however everything else is available for read only access. 2. Record warnings and errors to a log in executable directory for user reference. 3. Allow streamlined creation of issue to GitHub if it fails to load the game properly, including log, game information, and steam page (if it exists).
…while loading of faulty file easier to read. Add file name and name to GitHub issue functionality, make the error while loading of faulty file easier to read.
|
Download the artifacts for this pull request here: GUI:
CLI: |
…til it is ready Comment out the mechanism for automatic creation of a GitHub issue until it is ready. There may be externalities and other work that need to be done to mitigate issues such as duplicate issues/resolved loading issues in newer revisions/making issues based off of old versions of UndertaleModTool.
Miepee
left a comment
Miepee
left a comment
There was a problem hiding this comment.
As mentioned on Discord, I am very displeased with this PR.
We were discussing earlier, that this feature is low priority right now, needs its implementation properly thought out and should be ignored until the feature freeze for 0.5.0.0 is over.
You went ahead, and made your own Pull Request, disregarded the suggestions we told you were likely flawed, and are now pushing for this to get merged as soon as you can.
This is also not the first time, that you have shown a lack of cooperating as a team, and I don't know the reasons why you keep acting that way, but it would be helpful if you could stop that kind of behavior in the future.
| CanSave = false; | ||
| CanSafelySave = false; | ||
| } | ||
| else if (hadWarnings && data.LoadedCorrectly) |
There was a problem hiding this comment.
Isn't data.LoadedCorrectly redundant here because it's an else if?
3 participants
Description
Allow streamlined creation of issue to GitHub if it fails to load the game properly, including log, game information, MD5, and steam page (if it exists).This has been removed until safeguards are put in place to reduce adverse impact on the number of issues created. The removal of this feature has no other adverse impacts on the other features, and it is recommended to merge as is, so that this feature may be added with full functionality and safeguards in a future pull request.
Caveats
UndertaleModTool may possibly crash in an unexpected way due to partially loaded data. This may require more error handling in the new catch block in ReadUndertaleData or in other parts of the code. However, what else needs to be accounted for is unknown. No mechanism for clearing old logs has been implemented at this time in the tool itself. That will need to be done manually.
Notes
A fix has been implemented to prevent crashing of loading a room when no embedded texture pages exist.
TODO: Investigate bytecode 15 games that use GMS2.