Skip to content

Room order grid controls #1396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
zivmaor wants to merge 11 commits into
base: master
Choose a base branch
from
Draft

Room order grid controls #1396

zivmaor wants to merge 11 commits into from

Conversation

@zivmaor
Copy link
Contributor

@zivmaor zivmaor commented May 25, 2023 •
edited
Loading

Description

Fix #1370, Fix #1400.
Items can be moved up and down the list with - and + (faster when holding shift), and empty items can be inserted with ctrl+n.
video demonstration: https://github.com/krzys-h/UndertaleModTool/assets/63353113/47394c07-d4b8-4c68-aa8f-646f6375ce81

Caveats

  • The controls aren't useable via the mouse.
  • I'm unsure about ctrl+n as the keybind for inserting a new room, especially given that it's already taken for creating a new file.
  • I've made the textbox of UndertaleObjectReference non-focusable because it was taking the focus when clicking on it in the list, which means you can't scroll via keyboard or use any of the new controls. I've added a way to copy the name of the object via the context menu as a replacement for being able to directly copy the text.

Notes

@github-actions
Copy link

github-actions bot commented May 25, 2023 •
edited
Loading

Download the artifacts for this pull request here:

GUI:

CLI:

zivmaor and others added 2 commits May 25, 2023 04:00
@zivmaor
Merge branch 'krzys-h:master' into roomOrderGridControls
08a2294
@zivmaor
Fix incorrect moving
46b14c0 
When moving a distance greater than 1 the functions
would change the order of items around in weird and incorrect ways.

Fixed small bug when moving items in GMS1 games.
@zivmaor zivmaor marked this pull request as draft November 23, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Changing game object order in room editor changes flashing object in room canvas in GMS1 games. Make Room Order List more easily editable

1 participant

@zivmaor